Skip to content

Bug 2052696: Fix 002goodperl test failures #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justdave wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −0
Open

Bug 2052696: Fix 002goodperl test failures #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0ecd52
Bug 2052696: Fix 002goodperl test failures
justdave Jul 5, 2026
3a01f8e
Merge branch 'main' into bug-2052696-harmony
justdave Jul 6, 2026
540354e
Avoid a conflict with #168
justdave Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extensions/Example/template/en/default/setup/strings.txt.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
# Contributor(s):
# Max Kanat-Alexander <mkanat@bugzilla.org>

use 5.14.0;
use strict;
use warnings;

%strings = (feature_example_acme => 'Example Extension: Acme Feature',);

@mrenvoize mrenvoize Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will now throw a warning:

perl -c extensions/Example/template/en/default/setup/strings.txt.pl
Global symbol "%strings" requires explicit package name (did you forget to declare "my %strings"?) at extensions/Example/template/en/default/setup/strings.txt.pl line 24.
extensions/Example/template/en/default/setup/strings.txt.pl had compilation errors.

@mrenvoize mrenvoize Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.. we skip the 'use strict' in the top-level template/en/default/setup/strings.txt.pl.. we should probably also do that here too.. or better use:

our %strings = (feature_example_acme => 'Example Extension: Acem Feature',);


1;
4 changes: 4 additions & 0 deletions extensions/OldBugMove/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
# Max Kanat-Alexander <mkanat@bugzilla.org>

package Bugzilla::Extension::OldBugMove;

use 5.14.0;
use strict;
use warnings;

use constant NAME => 'OldBugMove';
__PACKAGE__->NAME;
4 changes: 4 additions & 0 deletions extensions/OldBugMove/Extension.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
# Max Kanat-Alexander <mkanat@bugzilla.org>

package Bugzilla::Extension::OldBugMove;

use 5.14.0;
use strict;
use warnings;

use base qw(Bugzilla::Extension);
use Bugzilla::Constants;
use Bugzilla::Error;
Expand Down
2 changes: 2 additions & 0 deletions extensions/OldBugMove/lib/Params.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@

package Bugzilla::Extension::OldBugMove::Params;

use 5.14.0;
use strict;
use warnings;

use Bugzilla::Config::Common;

Expand Down
3 changes: 3 additions & 0 deletions extensions/ShadowBugs/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
# defined by the Mozilla Public License, v. 2.0.

package Bugzilla::Extension::ShadowBugs;

use 5.14.0;
use strict;
use warnings;

use constant NAME => 'ShadowBugs';
use constant REQUIRED_MODULES => [];
Expand Down
2 changes: 2 additions & 0 deletions extensions/ShadowBugs/Extension.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

package Bugzilla::Extension::ShadowBugs;

use 5.14.0;
use strict;
use warnings;

use base qw(Bugzilla::Extension);

Expand Down
Loading