Skip to content

feat: add @path mentions and multi-file patch parsing#19

Merged
cachebag merged 6 commits into
masterfrom
feat/path-mentions
May 23, 2026
Merged

feat: add @path mentions and multi-file patch parsing#19
cachebag merged 6 commits into
masterfrom
feat/path-mentions

Conversation

@cachebag
Copy link
Copy Markdown
Owner

@cachebag cachebag commented May 23, 2026

Foundation for cross-file prompts #18: parse 'ATpath' from prompt text, load tagged file contents with size limits, and route SEARCH/REPLACE blocks to files by path.

Very rough and definitely still WIP but a good start.

@cachebag
feat: add @path mentions and multi-file patch parsing
982df15 
Foundation for cross-file prompts #18: parse @path from prompt text,
load tagged file contents with size limits, and route SEARCH/REPLACE
blocks to files by path.
@cachebag cachebag requested a review from LOTaher May 23, 2026 00:38
@cachebag cachebag self-assigned this May 23, 2026
@cachebag cachebag added feature New functionality area:llm Providers, API calls, system prompt area:prompt Floating prompt window labels May 23, 2026
@cachebag cachebag marked this pull request as draft May 23, 2026 00:41
cachebag added 2 commits May 22, 2026 20:44
@cachebag
feat: wire multi-file system prompt for @path mentions
ce29ab7 
When tagged files are present in the context, build_messages now
formats each file as a labeled block and appends instructions telling
the LLM to prefix SEARCH markers with the file path.
@cachebag
fix: require primary_path in apply_by_file instead of silently droppi…
d1e73dc 
…ng orphaned blocks
@cachebag cachebag marked this pull request as ready for review May 23, 2026 00:51
LOTaher
LOTaher reviewed May 23, 2026
View reviewed changes
Comment thread lua/jumpy/llm.lua Outdated
LOTaher
LOTaher approved these changes May 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LOTaher LOTaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LOTaher
Copy link
Copy Markdown
Collaborator

LOTaher commented May 23, 2026 •
edited
Loading

Unsure if you're planning on tackling the TODOs within this PR, but before you merge, just wanted to note a case I ran into:

  • If I call tags.find_mention using the string "@foo.lua." (notice period at the end), the trailing period is added to the path causing strip_mentions to keep the @ and return @foo.lua.. The same behavior happens with the / character too ie: @lua/jumpy/

@LOTaher LOTaher mentioned this pull request May 23, 2026
Merged
@cachebag cachebag force-pushed the feat/path-mentions branch from 3d055fd to d806e94 Compare May 23, 2026 13:29
@cachebag cachebag requested a review from LOTaher May 23, 2026 13:30
@cachebag cachebag merged commit 0a0b49e into master May 23, 2026
3 checks passed
@cachebag cachebag deleted the feat/path-mentions branch May 23, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LOTaher LOTaher Awaiting requested review from LOTaher

Assignees

@cachebag cachebag

Labels

area:llm Providers, API calls, system prompt area:prompt Floating prompt window feature New functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cachebag @LOTaher