chore: Coverts the first two notebooks in the automatic alternate abbreviation annotation workflow into modules - #157
Open
anastasiabratulin wants to merge 4 commits into
Open
chore: Coverts the first two notebooks in the automatic alternate abbreviation annotation workflow into modules#157anastasiabratulin wants to merge 4 commits into
anastasiabratulin wants to merge 4 commits into
Conversation
mcannon068nw
requested changes
Aug 4, 2026
mcannon068nw
left a comment
mcannon068nw
left a comment
Contributor
There was a problem hiding this comment.
Only one major concern in the run_samples file. If you can address that I think this all should be good
Comment on lines
+119
to
+120
| # TODO: After manually annotating the new rows in alt_abbrev_annotation_to_annotate_df.xlsx, it needs to be renamed and saved | ||
| # to alt_abbrev_annotation_**manually_annotated**_df.xlsx |
Contributor
There was a problem hiding this comment.
Do you have an issue made for this
Contributor
Author
There was a problem hiding this comment.
I used the TODO to highlight that a user would have to manually rename the file after manually annotating the new rows with the alternate abbreviation classification. Is there a different way I should do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #107
closes #143