fix(gorgone): correctly delete poller for pull communication type#3464
Open
Evan-Adam wants to merge 12 commits into
Open
fix(gorgone): correctly delete poller for pull communication type#3464Evan-Adam wants to merge 12 commits into
Evan-Adam wants to merge 12 commits into
Conversation
Evan-Adam
requested review from
jean-christophe81 and
sdepassio
and removed request for
a team
June 16, 2026 16:38
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refs:MON-197880
… add test for push with uuid. Refs:MON-197880
Before this, when an order was sent to an uid, it was not sent to the correct gorgone identity Refs:MON-197880
Evan-Adam
force-pushed
the
MON-197880-gorgone-fix-uid-identification
branch
from
July 7, 2026 12:53
078bb8d to
33392b1
Compare
Refs:MON-197880
Refs:MON-197880
…ullwss Refs:MON-197880
Refs:MON-197880
Refs:MON-197880
if poller is configured in pull mode with id, and receive a COMMAND message with an uid, the message is thrown away. Another ticket will fix this Refs:MON-197880
omercier
approved these changes
Jul 13, 2026
sdepassio
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:MON-197880
Description
When poller exist in database and are deleted but still try to connect with pull communication type (don't happend pullwss mode) there was multiples perl error in the logs.
Now a clear log indicate to the user that the poller do not exist and no perl error are present. automated tests had been modified to test that, even if a real test would wait more than one minute, as poller reconnection happend only every minutes.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
See automated test, you should create a central with a poller in pull communication mode, and delete the row in DB, force central to read database again, and wait for error in the central log.
Checklist