Open
Conversation
added 10 commits
April 18, 2026 17:08
Fixed visual inconsistencies in border-radii, colors, and scales
Refactored BackgroundImageSettings with a modern grid layout, improved image loading states, and integrated Cephie Snap cloud gallery. Standardized design tokens to match the new zinc-800/30 glass system.
Unified design language across settings components to resolve visual drift. - Standardized border-radii (xl for containers, lg for items). - Synchronized color palette using zinc-900/50 backgrounds and zinc-800/40 section cards. - Normalized icon box sizing (p-2.5) and typography scales. - Refactored toggle switches and buttons to use shared Tailwind utility patterns.
Eliminated visual drift in the privacy module by: - Replacing custom border-2 and gradient backgrounds with standardized zinc-800/40 section cards. - Normalizing icon box sizes and switching from solid color fills to subtle 10% opacity tints. - Consolidating 5 unique handlers into a single dynamic toggle function for better maintainability. - Aligning toggle switch scales and animation durations with the rest of the settings page. - Implementing a mapping system for settings to reduce redundant JSX boilerplate.
Resolved visual drift in BackgroundSettings: - Applied shared container and section TOKENS for radius and border parity. - Synchronized header typography and icon spacing. - Replaced custom sizing logic with standardized Button components. - Normalized color usage to align with the zinc-based theme.
1ceit
reviewed
Apr 18, 2026
Collaborator
1ceit
left a comment
1ceit
left a comment
There was a problem hiding this comment.
Good start. Banana will have comments on specific design characteristics. Also docker compose dev should be fixed now. So use that instead.
Collaborator
There was a problem hiding this comment.
This shouldn't be changed as this is for prod. If you need to change something use the dev compose
Collaborator
There was a problem hiding this comment.
We try not to use css files. If there are styles we want to apply a lot add to globals.css
Author
|
The most should be fixed as requested. If anything missing recomment thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves design consistency across the Settings page by introducing a shared styling system and unifying UI components.
Previously, the Settings page was composed of multiple independently developed components, resulting in visual inconsistencies across the interface.
Changes made:
settingstoken.tsas a centralized design token system for consistent stylingsettings-slider.cssto provide consistent custom styling for slider inputs (volume and opacity)