Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds target user identification to audit logs so actions can be tied to the affected user.
- Add targetUserId to the audit log payload
- Populate from request body with a null fallback
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| adminId: req.user.userId, | ||
| adminUsername: req.user.username || 'Unknown', | ||
| actionType, | ||
| targetUserId: req.body?.userId || null, |
There was a problem hiding this comment.
targetUserId is pulled directly from req.body, which is client-controlled and can be spoofed, leading to misleading audit trails. Derive the target user ID from a trusted source (e.g., route params, server-side resolved entity, or a value placed on res.locals by prior middleware) and validate its type before logging.
Suggested change
| targetUserId: req.body?.userId || null, | |
| targetUserId: (typeof res.locals.targetUserId === 'string' || typeof res.locals.targetUserId === 'number') ? res.locals.targetUserId : null, |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.