Skip to content

Fix Atis encryption, fix avatars, fix atis reminder location#40

Merged
1ceit merged 2 commits intomainfrom
UpdateACARSChartsDrawer
Oct 19, 2025
Merged

Fix Atis encryption, fix avatars, fix atis reminder location#40
1ceit merged 2 commits intomainfrom
UpdateACARSChartsDrawer

Conversation

@1ceit
Copy link
Copy Markdown
Collaborator

@1ceit 1ceit commented Oct 19, 2025

Backend Security Enhancements

  • ATIS data is now encrypted before being stored or updated in the database, and decrypted when accessed or transmitted via websockets. This affects endpoints in server/routes/atis.ts, server/routes/sessions.ts, and websocket handlers in server/websockets/sessionUsersWebsocket.ts. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Frontend User Experience Improvements

  • Fixed Discord User Avatars in acars sidebar [1] [2] [3] [4]
  • When creating a session on the PFATC network, users are shown a modal reminding them of the ATIS format, with relevant session and airport information. This modal is conditionally rendered in src/pages/Create.tsx and uses the new AtisReminderModal component. [1] [2] [3] [4]

UI and Display Refinements

  • ACARS terminal messages now show a timestamp and station label for each message, improving readability and context for users.
  • The ATIS reminder modal has updated styling for a more modern look, using a gradient background and improved border.

Minor Frontend Adjustments

  • Chart image loading state in AcarsChartDrawer is now managed using a useEffect hook, and redundant onLoadStart handlers are removed for cleaner image loading logic. [1] [2] [3] [4]
  • Unused imports and state related to the ATIS reminder modal have been removed from src/pages/Flights.tsx for code cleanliness. [1] [2]

@1ceit 1ceit requested review from Copilot and dev-banane October 19, 2025 05:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements ATIS encryption, fixes Discord avatar display in the ACARS sidebar, and relocates the ATIS reminder modal from the Flights page to the Create page. The changes enhance security by encrypting ATIS data at rest while maintaining functionality through proper encryption/decryption in the backend routes and websocket handlers. User experience improvements include fixing avatar URLs and showing the ATIS format reminder at session creation time for PFATC networks.

Key changes:

  • ATIS data encryption/decryption across backend endpoints and websockets
  • Discord avatar URL construction and display in ACARS sidebar and overview
  • ATIS reminder modal moved from Flights page to Create page with proper state management

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
server/routes/atis.ts Encrypts ATIS data before storing and updates response field names
server/routes/sessions.ts Adds encryption/decryption for ATIS in GET and PUT endpoints
server/websockets/sessionUsersWebsocket.ts Implements ATIS encryption/decryption in websocket handlers
server/websockets/overviewWebsocket.ts Constructs Discord avatar URLs for controllers
src/pages/Create.tsx Adds ATIS reminder modal display after session creation for PFATC
src/pages/Flights.tsx Removes ATIS reminder modal and adds position-based departure filtering
src/components/acars/AcarsSidebar.tsx Uses avatar field from controller data for display
src/components/acars/AcarsTerminal.tsx Adds timestamp and station labels to terminal messages
src/components/acars/AcarsChartDrawer.tsx Refactors image loading state with useEffect
src/components/modals/AtisReminderModal.tsx Updates modal styling with gradient background
src/sockets/overviewSocket.ts Adds optional avatar field to controller interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread server/routes/atis.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@CoolerMinecraft CoolerMinecraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@1ceit 1ceit merged commit c8887b6 into main Oct 19, 2025
1 check passed
@1ceit 1ceit deleted the UpdateACARSChartsDrawer branch October 20, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants