-
-
Notifications
You must be signed in to change notification settings - Fork 3
Fixes #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixes #43
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
747e458
Home CTA redesign
dev-banane b1aef3b
navbar stuff
dev-banane a476ac7
EditableFields debouncing
dev-banane cb0a136
Chat fixes
dev-banane f0c9494
Acars & Chart design adjustment
dev-banane 6d117ea
double counting fix
dev-banane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -313,7 +313,6 @@ export default function Navbar({ sessionId, accessId }: NavbarProps) { | |
| <p className="text-sm font-medium text-white leading-tight flex-1"> | ||
| {notification.text} | ||
| </p> | ||
| {/* New: Hide button */} | ||
| <button | ||
| onClick={() => hideNotification(notification.id)} | ||
| className="flex-shrink-0 ml-2 text-white hover:text-gray-300 transition-colors" | ||
|
|
@@ -500,30 +499,6 @@ export default function Navbar({ sessionId, accessId }: NavbarProps) { | |
| } | ||
| `} | ||
| > | ||
| <div className="py-2"> | ||
| <a | ||
| href="/create" | ||
| className="block px-6 py-3 text-gray-300 hover:text-white hover:bg-blue-600/20 transition-all duration-200 font-medium" | ||
| onClick={() => setIsMenuOpen(false)} | ||
| > | ||
| Create Session | ||
| </a> | ||
| <a | ||
| href="/sessions" | ||
| className="block px-6 py-3 text-gray-300 hover:text-white hover:bg-blue-600/20 transition-all duration-200 font-medium" | ||
| onClick={() => setIsMenuOpen(false)} | ||
| > | ||
| My Sessions | ||
| </a> | ||
| <a | ||
| href="/pfatc" | ||
| className="block px-6 py-3 text-gray-300 hover:text-white hover:bg-blue-600/20 transition-all duration-200 font-medium" | ||
| onClick={() => setIsMenuOpen(false)} | ||
| > | ||
| PFATC Flights | ||
| </a> | ||
| </div> | ||
|
|
||
|
Comment on lines
-503
to
-526
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Am I missing something? |
||
| <div className="border-t border-zinc-700/50 p-4"> | ||
| <CustomUserButton | ||
| isMobile={true} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number
0.1(6 seconds) is used without explanation. Consider defining this as a named constant (e.g.,DISCONNECT_BUFFER_MINUTES) with a comment explaining why this buffer is necessary.