This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Set hostname and port through environment variable#45
Open
christaina wants to merge 2 commits intocerndb:masterfrom
Open
Set hostname and port through environment variable#45christaina wants to merge 2 commits intocerndb:masterfrom
christaina wants to merge 2 commits intocerndb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a small change where
master_hostandmaster_portare read from optional environment variables (if they are not present behavior stays the same). In our use case we need to specify both the host and port because we are running dist-keras on Docker. I thought it would be useful for others who are using Docker or in the case where the Spark master is running in a container. For us using environment variables rather than passing these in as parameters makes more sense because we don't want everyone using this package in our system to have to worry about this. Hope this is helpful.