Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
You have to configure the github token to run them. I run them OK in the past locally but lately I just relied on the CI - cause I didn't want to create a fresh token ;p |
| .ROOT_TEST_BRANCH_PREFIX as string; | ||
| export const ROOT_TEMP_DIRECTORY = process.env.ROOT_TEMP_DIRECTORY as string; | ||
|
|
||
| configDotenv(); |
There was a problem hiding this comment.
It feels weird/wrong that this comes after unpacking the variables from process.env
There was a problem hiding this comment.
I have a lot of opinions and how it's set up too but I didn't want too touch too much 😄
| "format:fix": "prettier --write \"**/*.{ts,tsx,md}\"", | ||
| "lint": "eslint . --max-warnings 0", | ||
| "test:integration": "jest --config jest.integration.config.cjs" | ||
| "test:integration": "vitest -c vitest.integration.config.ts" |
There was a problem hiding this comment.
we even have any other tests? it feels like this is just the default test suite here and we perhaps don't need to nest/namespace it under integration name
There was a problem hiding this comment.
I changed it to test initially but since this is quite involved to run locally, I kept the "integration" part so you don't run pnpm test and expect it too easily pass.
2 participants
No idea if this works. It's quite hard to run the tests.