Stabilize emoji use in tests#194
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe pixi.toml file's Changespixi.toml task environment update
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 1 individual chapter for you:
Chapters generated by Stage for commit 60ba58a on Jul 3, 2026 11:29pm UTC. |
Before this patch, some test results were unstable:
```
4 │-✔ Default toolchain set to version 'latest'
4 │+Default toolchain set to version 'latest'
```
This is because `console` crate uses `LANG` for check that we should use
emoji or not.
https://github.com/console-rs/console/blob/0.16.3/src/unix_term.rs#L389-L396
To stabilize the results, this patch adds the environment variable
`LANG` for tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 24 24
Lines 1429 1429
=======================================
Hits 1283 1283
Misses 146 146 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Rebased. |
|
I think it would be more appropriate to put this env var in the |
Depends on #188(merged)Before this patch, some test results were unstable:
This is because
consolecrate usesLANGfor check that we should useemoji or not.
https://github.com/console-rs/console/blob/0.16.3/src/unix_term.rs#L389-L396
To stabilize the results, this patch adds the environment variable
LANGfor tests.