Issue #581 - coerce attribute names to lower case in HTML mode#3306
Open
davidfei222 wants to merge 14 commits intocheeriojs:mainfrom
Open
Issue #581 - coerce attribute names to lower case in HTML mode#3306davidfei222 wants to merge 14 commits intocheeriojs:mainfrom
davidfei222 wants to merge 14 commits intocheeriojs:mainfrom
Conversation
Co-authored-by: rjpatt <racheljpatterson@gmail.com> Co-authored-by: davidfei222 <davidfei222@gmail.com>
|
This PR updates Cheerio's |
|
Adjusted a few existing tests to be able to support tests for this fix. |
Member
|
Thanks a lot for this PR! Some notes:
attrNameToUse = this.options.xmlMode ? attrName : attrName.toLowerCase() |
Author
|
@fb55 Apologies for the late response - my colleagues and I have been very busy at work recently. The requested changes have been made - please re-review at your earliest convenience. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #581. Attribute names will now always be coerced to lower case when attempting to get or set attributes to keep the behavior in line with how cheerio.load() handles attribute names.