Update encoding sniffer to latest version 1.0.2#5163
Closed
ajaymathur wants to merge 1 commit intocheeriojs:mainfrom
Closed
Update encoding sniffer to latest version 1.0.2#5163ajaymathur wants to merge 1 commit intocheeriojs:mainfrom
ajaymathur wants to merge 1 commit intocheeriojs:mainfrom
Conversation
|
This PR is the same as #5157, which has a linting failure because |
Member
|
Hi @ajaymathur, thanks for raising! encoding-sniffer is esm-only now, and I'm currently working through the dependency tree of cheerio to make all other modules esm-only as well. |
Author
|
Thanks @fb55 , please let me know if I can help in anyway. :) |
|
I left some comments on that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4977
Upgraded encoding-sniffer to latest version.
Local testing state
I was not able to run unit tests or lint in local due to error:
I have raised the PR to verify these in github checks while I try to get local testing up.