Add exclude_from_fixture_relationships check in ManyManyThroughFields#34
Merged
chrispenny merged 2 commits intochrispenny:mainfrom Mar 29, 2026
Merged
Conversation
chrispenny
reviewed
Mar 29, 2026
Comment on lines
+546
to
+553
| // Check to see if this class has requested that it not be included in relationship maps | ||
| $excludeClass = Config::inst()->get($relatedObject->ClassName, 'exclude_from_fixture_relationships'); | ||
|
|
||
| // Yup, exclude this class | ||
| if ($excludeClass) { | ||
| continue; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
I'm trying to decide if we need this.
My gut feeling is that there is no harm in tracking this as a resolved relationship.
chrispenny
force-pushed
the
fix/add-exclude-check-for-many-many
branch
from
735ab5e to
f363d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating fixtures of site config, it does not exclude Member and Groups.
Added the
exclude_from_fixture_relationshipscheck for many_many relations.