fix: pass through navigation keys when tmux can't move - #472
Open
imkgh wants to merge 1 commit into
Open
Conversation
imkgh
changed the title
imkgh
changed the title
When not in Vim, only run select-pane if an adjacent pane exists (and optionally when not zoomed). Otherwise send the key through so default bindings like Ctrl-l (clear screen) still work in single-pane or at pane edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes pane-navigation keybindings smarter by only running
select-panewhen it can actually succeed. When the window is zoomed or there is no neighboring pane in the requested direction, the key is passed through to the application instead.Motivation
Prevent no-op
select-panein zoomed windows or at pane edges from swallowing navigation keys; pass them through to the app instead.Behavior matrix
send-keys <key>(unchanged).select-pane(navigation).send-keys <key>(pass-through).Tested
resize-pane -Z) or at pane edges / single pane.