introduce or function#179
Open
oldaccountdeadname wants to merge 2 commits intochyh1990:masterfrom
Open
Conversation
Similarly to `or` for Rust's options, this patch provides a way to 'override' the value of a Yaml node if it's some form of error.
Author
|
looks like checks are failing --- tests pass on my machine, so I'm not entirely sure what's going on there. Looking at the logs, it looks like the windows-gnu builds are failing due to a missing mingw build, though I'm not familiar with this CI system and don't really know how to fix that. |
Allow the usage of `or` without consuming self. This can be useful for pipelines that maintain some sort of owned state.
|
FWIW I've merged this into my fork: https://github.com/davvid/yaml-rust/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to
orfor Rust's options, this patch provides a way to 'override' the value of a Yaml node if it's some form of error.It's a pretty small patch: if this type of albeit trivial manipulation is beyond the scope of the library, feel free not to merge! Thanks!