fix: keep alive host data in uws_app_listen_with_config #212#227
Open
goteguru wants to merge 1 commit intocirospaciari:mainfrom
Open
fix: keep alive host data in uws_app_listen_with_config #212#227goteguru wants to merge 1 commit intocirospaciari:mainfrom
goteguru wants to merge 1 commit intocirospaciari:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #212
Minimal change to keep alive char[] for host data in listen() call.
uws_app_listen_config_t struct has a host field which is a char* pointer, therefore we create a string (ffi.new("char[]", host)) if necessary. Later we save the uws_app_listen_config_t ffi struct to self.native_options_listen in order to keep it alive, what is correct, but we don't save the string. The pointer doesn't own the string, it might be freed and overwritten by garbage.
This trivial patch fixes that.