fix(builder): Take &self in ArgGroup::is_multiple - #6411
Open
mistaste wants to merge 1 commit into
Open
Conversation
`ArgGroup::is_multiple` is a getter that doesn't mutate, but required `&mut self`. That prevented calling it on a shared reference, such as one obtained from `Command::groups`. Relax the receiver to `&self`. Fixes clap-rs#4708
Member
|
Note that a previous PR existed for #4708 and was deferred due to it being a breaking change. We might be able to put this behind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4708.
ArgGroup::is_multipleis a getter that just returnsself.multiple, but itrequired
&mut self. That made it impossible to call on a shared reference,such as one obtained from
Command::groups.This relaxes the receiver to
&self, which is backwards compatible (existingcallers holding a
&mut ArgGroupcan still call it). The doc example and unittest are updated accordingly, and the test now also exercises calling the getter
through a
&ArgGroup.cargo test -p clap_builder,--doc,cargo clippy --all-featuresandcargo fmt --checkall pass.