Move running disparity out of Sgmii core - #69
Draft
jvnknvlgl wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds variants of the 8b10b line coder that have a state variable to store the running disparity instead of storing the running disparity in the Sgmii core, and also attempts to port the Sgmii core to use this variant of the line coder. This currently does not work, and getting this to work is the problem I have been stuck on for the last few months.
The reason I want to move to this setup is because in order to combine the 3b4b and 5b6b encoder (see #68) into a hopefully simpler 8b10b encoder, it needs to know the current running disparity as part of its state. This combination is the last phase, which I have not yet worked on.