feat: Add peer address to downstream handshake error logs#536
feat: Add peer address to downstream handshake error logs#536jsulmont wants to merge 9 commits intocloudflare:mainfrom
Conversation
|
@drcaramelsyrup I am not sure why the build 1.72.0 failed -- the previous push passed both 1.72 and 1.82 (failed bnightly) |
@jsulmont Sorry, I realize I led you down the wrong path with my suggestion. Your original change actually seems fine now, because I was mistaken - today we already set the As it stands it's not possible to do what I had originally suggested because the handshake function moves the io stream. |
|
@matthewbjones there's now a test failing for 1.72 in |
|
Looks like it was a flaky test. We'll get this change reviewed internally. |
drcaramelsyrup
left a comment
drcaramelsyrup
left a comment
There was a problem hiding this comment.
This now essentially lgtm will some minor nits I'd like to see, I can also make these changes in a separate commit internally if you'd like.
All good, I've pushed a commit towards addressing your two comments above -- thanks @drcaramelsyrup |
…o-handshake-errors
|
@drcaramelsyrup still the tests::test_eviction failing |
drcaramelsyrup
added
the
Accepted
|
Thanks, we've merged internally and the change should be present in a future sync. |
Thank you 🙏🏻 |
…o-handshake-errors
--- refactor: replace match with let binding for cleaner code --- fix: optimize syscall usage in handshake error logging --- Revert "fix: optimize syscall usage in handshake error logging" This reverts commit 0724afc. --- Refactor peer_addr() using method chaining with and_then/map combinators --- Merge remote-tracking branch 'upstream/main' into fix/add-peer-addr-to-handshake-errors --- fix: Use proper SocketAddr type and move peer address retrieval inside async closure Includes-commit: 0724afc Includes-commit: 20b2e8f Includes-commit: 224ea8a Includes-commit: 71e43d4 Includes-commit: c2333b3 Includes-commit: cfa7d33 Includes-commit: eecf06d Replicated-from: #536
--- refactor: replace match with let binding for cleaner code --- fix: optimize syscall usage in handshake error logging --- Revert "fix: optimize syscall usage in handshake error logging" This reverts commit 0724afc. --- Refactor peer_addr() using method chaining with and_then/map combinators --- Merge remote-tracking branch 'upstream/main' into fix/add-peer-addr-to-handshake-errors --- fix: Use proper SocketAddr type and move peer address retrieval inside async closure Includes-commit: 0724afc Includes-commit: 20b2e8f Includes-commit: 224ea8a Includes-commit: 71e43d4 Includes-commit: c2333b3 Includes-commit: cfa7d33 Includes-commit: eecf06d Replicated-from: #536
|
This landed in our sync yesterday, thank you! |
4 participants
Add peer address to handshake error logs
Fixes #535