Temporary sfv solution#572
Closed
zonblade wants to merge 1 commit intocloudflare:mainfrom
Closed
Conversation
|
it seems there is already a pr |
Author
|
For extra context, I think sfv technically might have already have an implied 1.77 msrv, even in |
Collaborator
|
Sorry for the delay on this, and thanks for the PR. We had merged a commit internally that also ended up taking this approach: 1c484ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw @BSteffaniak as long term solution to bump the things so it could match the sfv version and their fixed which explained in this PR #569, but i see there is still rust 1.72 in the pingora build-test. So I propose to downgrade temporarily until maintainers came up with the decision
sfvbreaking changes #569 PRwhich on this PR i change from
0to exact0.10.4last working version