Update and pin sfv to v11 #568#597
Closed
dominictobias wants to merge 4 commits intocloudflare:mainfrom
dominictobias:fix/sfv-version-upgrade-568
Closed
Update and pin sfv to v11 #568#597dominictobias wants to merge 4 commits intocloudflare:mainfrom dominictobias:fix/sfv-version-upgrade-568
dominictobias wants to merge 4 commits intocloudflare:mainfrom
dominictobias:fix/sfv-version-upgrade-568
Conversation
Contributor
|
This is a duplicate of - #569 - that will be merged soon. We're trying to decide what to do about the msrv change it will inflict. Thanks though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated and pinned to v11 after I saw someone has already pinned to the last working version in unreleased code: 1c484ce
Anyway, here it is, if you want to update to v11
sfvv11 requires a min rust version of 1.77.0At the moment pingora is broken on install - #568