Skip to content

fix(image_variant): fix image variant tests#6918

Open
syvelasquez10 wants to merge 1 commit into
cloudflare:nextfrom
syvelasquez10:IMAGES-1782-v2
Open

fix(image_variant): fix image variant tests#6918
syvelasquez10 wants to merge 1 commit into
cloudflare:nextfrom
syvelasquez10:IMAGES-1782-v2

Conversation

@syvelasquez10

Copy link
Copy Markdown

The upstream SDK returns all image variant API responses with data nested under result.variant. Update all CRUD operations (Create, Read, Update, ImportState) to use ImageVariantWriteResultEnvelope which correctly deserializes the nested response structure.

  • Remove redundant variant computed field from resource schema and model
  • Remove unused ImageVariantResultEnvelope (flat envelope)
  • Add ImageVariantWriteResultEnvelope for nested response deserialization
  • Add acceptance tests for resource (basic, update, import) and data source
  • Update docs for resource and data source
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Acceptance test run results

  • [ X] I have added or updated acceptance tests for my changes
  • [ X] I have run acceptance tests for my changes and included the results below

Steps to run acceptance tests

Test output

Additional context & links

…dd acceptance tests

The upstream SDK returns all image variant API responses with data nested
under result.variant. Update all CRUD operations (Create, Read, Update,
ImportState) to use ImageVariantWriteResultEnvelope which correctly
deserializes the nested response structure.

- Remove redundant variant computed field from resource schema and model
- Remove unused ImageVariantResultEnvelope (flat envelope)
- Add ImageVariantWriteResultEnvelope for nested response deserialization
- Add acceptance tests for resource (basic, update, import) and data source
- Update docs for resource and data source
@syvelasquez10
syvelasquez10 requested a review from a team as a code owner March 13, 2026 18:21
@syvelasquez10
syvelasquez10 marked this pull request as draft March 13, 2026 18:21
@stainless-app
stainless-app Bot force-pushed the next branch 6 times, most recently from db5b37e to 34540ed Compare April 15, 2026 01:43
@syvelasquez10
syvelasquez10 marked this pull request as ready for review April 29, 2026 15:32
@stainless-app
stainless-app Bot force-pushed the next branch 6 times, most recently from 54323e1 to ed3bbb2 Compare April 29, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant