fix: Ensure that ctx and env __init__ arguments are always wrapped#131
Merged
Merged
Conversation
ryanking13
reviewed
Jun 19, 2026
hoodmane
force-pushed
the
hoodmane/fix-wrap-init-args
branch
2 times, most recently
from
7bdfe04 to
39cb7de
Compare
ryanking13
approved these changes
Jul 1, 2026
ryanking13
left a comment
ryanking13
left a comment
Contributor
There was a problem hiding this comment.
Thanks. could you add a testcase that wasn't covered by the previous patch?
Contributor
Author
|
The updates to the test suite did not pass before the change. |
We fixed the double-wrapping problem in cloudflare#126 but added a new problem that ctx and env args in subclasses won't be wrapped at all. This switches to wrapping all __init__ functions but making DurableObjectContext and _EnvWrapper idempotent so that double wrapping them is not possible.
hoodmane
force-pushed
the
hoodmane/fix-wrap-init-args
branch
from
39cb7de to
f76e9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fixed the double-wrapping problem in #126 but added a new problem that ctx and env args in subclasses won't be wrapped at all. This switches to wrapping all init functions but making DurableObjectContext and _EnvWrapper idempotent so that double wrapping them is not possible.