chore: add smoke tests for packages that have entropy patches#133
Open
ryanking13 wants to merge 9 commits into
Open
chore: add smoke tests for packages that have entropy patches#133ryanking13 wants to merge 9 commits into
ryanking13 wants to merge 9 commits into
Conversation
|
I'm Bonk, and I've done a quick review of your PR. This PR adds smoke tests for packages that rely on entropy patches, verifying they survive the workerd snapshot save/restore cycle. The overall structure follows existing conventions well (matches the I flagged one issue:
|
hoodmane
reviewed
Jun 20, 2026
dom96
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are patching these packages. I think it should be useful for us to have test coverage so we don't suddenly break these packages. I found that in newer pydantic-core version (which is available in Python 3.14), our entropy patch doesn't work (#132). I believe these tests will allow us catching those errors when 1) we update Python versions, or when 2) those packages release a new version with breaking changes in entropy.