chore: fix rpc test not collected#137
Merged
Merged
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR migrates the RPC test from a deprecated global test handler to a test method on the Default(WorkerEntrypoint) class, and fixes assert_equal to accept dict subclasses.
Issues
- Medium: Two test cases silently dropped. The old code tested that passing a
lambdaand a nameddef my_functoenv.PythonRpc.identity()raisesTypeError. These were removed without explanation. If they were dropped intentionally (e.g. thedefinsidewithblock was problematic), it would be good to note why — otherwise they should be kept.
|
I'm Bonk, and I've done a quick review of your PR. This PR migrates the RPC test from a deprecated global I found one actionable issue and posted a review comment on the PR:
The rest of the changes (structural migration to class method, |
ryanking13
commented
Jun 22, 2026
dom96
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
python-rpc/worker.pytests were not running at all because it had a globaltestfunction which we deprecated.This migrates it to
testmethod under theWorkerEntrypointclass.