feat(#174660): add new code conventions rules by kirill-pyatunin · Pull Request #1 · clutcher/spring-modulith-module-archunit

kirill-pyatunin · 2026-03-18T10:00:45Z

No description provided.

kirill-pyatunin · 2026-04-23T10:09:48Z

+                moduleBasePackage + properties.getDomainModelPackageMatcher(),
+                "java..",


move to props

kirill-pyatunin · 2026-04-23T10:10:20Z

+        return noClasses()
+                .that().resideInAPackage(moduleBasePackage + properties.getDomainPackageMatcher())
+                .should().dependOnClassesThat(
+                        resideInAPackage("..app.domain..")


kirill-pyatunin · 2026-04-23T10:14:54Z

+                .that().resideInAPackage(moduleBasePackage + properties.getDomainPackageMatcher())
+                .should().dependOnClassesThat(
+                        resideInAPackage("..app.domain..")
+                                .and(resideOutsideOfPackage(moduleBasePackage + ".."))


? check and remove

kirill-pyatunin · 2026-04-23T10:18:22Z


    String getApplicationRoot();
+
+    default String getDomainModelPackageMatcher() {


check. it should already exists in configs

kirill-pyatunin · 2026-04-23T10:24:10Z

+                .allowEmptyShould(true);
+    }
+
+    public static ArchRule ruleForCrossModuleDomainIsolation(String moduleBasePackage, HexagonalArchitectureSettings properties) {


kirill-pyatunin · 2026-04-23T10:28:16Z

+                .allowEmptyShould(true);
+    }
+
+    public static ArchRule ruleForDomainModelNotExposedInDrivingAdapters(String moduleBasePackage, HexagonalArchitectureSettings properties) {


Check rule *Test that domain.model is not used to be returned from in rest controller - only for controllers

*Mapper class
mappers package?

kirill-pyatunin · 2026-04-23T10:31:14Z

+                .allowEmptyShould(true);
+    }
+
+    static DescribedPredicate<JavaClass> areNotAnnotatedWithAnyOf(String[] annotationNames) {


not arch rule - move

kirill-pyatunin · 2026-04-23T10:34:25Z

+                moduleBasePackage + properties.getDomainModelPackageMatcher(),
+                "java..",
+                "lombok..",
+                "org.springframework.stereotype..",


too wide. component and service

kirill-pyatunin · 2026-04-23T10:36:42Z

+        };
+    }
+
+    public static ArchRule ruleForNoAutowiredInDomain(String moduleBasePackage, HexagonalArchitectureSettings properties) {


kirill-pyatunin · 2026-04-23T10:37:11Z

+                .allowEmptyShould(true);
+    }
+
+    public static ArchRule ruleForNoAutowiredFieldsInDomain(String moduleBasePackage, HexagonalArchitectureSettings properties) {


kirill-pyatunin · 2026-04-23T10:38:54Z

+                .allowEmptyShould(true);
+    }
+
+    public static ArchRule ruleForDomainModelOnlyRecordsOrPojos(String moduleBasePackage, HexagonalArchitectureSettings properties) {


should check records or pojos

kirill-pyatunin · 2026-04-23T10:49:33Z

+                .allowEmptyShould(true);
+    }
+
+    public static ArchRule ruleForSpringAdapterNaming(String moduleBasePackage, HexagonalArchitectureSettings properties) {


kirill-pyatunin · 2026-04-23T10:54:40Z

+    }
+
+
+    // --- Custom ArchConditions ---


move ArchConditions

kirill-pyatunin · 2026-04-23T10:56:39Z

+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.fields;
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses;
+
+public class CodeConventionsRulesLibrary {


create interface.
Create property to allow on/off or redefine rules, add rule

id rule = true / false, true by default (exmpl)

kirill-pyatunin · 2026-04-23T10:58:23Z

@@ -0,0 +1,24 @@
+dev:


kirill-pyatunin · 2026-04-23T11:01:28Z

-extra["springBootVersion"] = "3.5.3"
+extra["springModulithVersion"] = "2.0.3"
+extra["springBootVersion"] = "4.0.2"
 extra["archUnitVersion"] = "1.4.1"


feat(#174660): add new code conventions rules

119dc57

kirill-pyatunin commented Apr 23, 2026

View reviewed changes

		moduleBasePackage + properties.getDomainModelPackageMatcher(),
		"java..",


		String getApplicationRoot();

		default String getDomainModelPackageMatcher() {

Conversation

kirill-pyatunin commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirill-pyatunin Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirill-pyatunin Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirill-pyatunin Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirill-pyatunin Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kirill-pyatunin Apr 23, 2026 •

edited

Loading

kirill-pyatunin Apr 23, 2026 •

edited

Loading

kirill-pyatunin Apr 23, 2026 •

edited

Loading

kirill-pyatunin Apr 23, 2026 •

edited

Loading