fix(gherkin): emit test.before/after with real current test#5580
Merged
DavertMik merged 1 commit intoMay 27, 2026
Merged
Conversation
Gherkin beforeEach/afterEach pass Mocha hook Context into setup/teardown,
but asyncWrapper read suite.ctx.currentTest (undefined on Context), so
event.test.before received a placeholder test (title "...", empty tags).
Also forward Mocha's done callback instead of no-op () => {}, so
event.test.before completes before scenario Background Before hooks run.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@danikkrapivnitskiy looks good but I would prefer to see an acceptance test for this case Also if possible I would prefer opposite order: |
Contributor
|
I checked the fix work fine for BDD projects |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gherkin beforeEach/afterEach pass Mocha hook Context into setup/teardown, but asyncWrapper read suite.ctx.currentTest (undefined on Context), so event.test.before received a placeholder test (title "...", empty tags).
Also forward Mocha's done callback instead of no-op () => {}, so event.test.before completes before scenario Background Before hooks run.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)