fix(celery): Prevent ChordError from Redis socket timeouts#1543
Open
sentry[bot] wants to merge 1 commit into
Open
fix(celery): Prevent ChordError from Redis socket timeouts#1543sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 1325 1325
Lines 50923 50923
Branches 1631 1631
=======================================
Hits 46771 46771
Misses 3842 3842
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChordErrorwas observed when a Celery chord task completed, and during the process of updating the chord's state in Redis, aTimeoutError('Timeout reading from socket')occurred. This happened because the Redis connection pool returned a stale or closed socket, leading to an immediate timeout when attempting to read from it. Since Celery propagates any failure within a chord, this single connection issue caused the entire chord to fail.This fix addresses the underlying Redis connection instability by enhancing the
result_backend_transport_optionsinBaseCeleryConfig. Specifically, it:retry_on_timeout=Trueto automatically retry transient Redis socket timeouts, preventing them from being stored as task failures.health_check_interval=30to periodically ping idle connections, helping to detect and evict stale connections before reuse.socket_timeout=5andsocket_connect_timeout=5to ensure read and connection attempts fail quickly if the Redis server is unresponsive.socket_keepalive=Trueto enable TCP keepalive probes, allowing the operating system to detect and close dead connections at the network level.These changes improve the resilience of Celery's Redis result backend, reducing the likelihood of
ChordErrordue to network or Redis server-side connection issues.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-Z1A