refactor: centralize Query Builder join compilation#10237
Open
memleakd wants to merge 1 commit into
Open
Conversation
- Move shared JOIN type and condition compilation into BaseBuilder - Let SQLSRV customize only JOIN table-name compilation - Add SQLSRV regression coverage for multi-condition and RawSql joins Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors Query Builder
JOINcompilation so the shared condition handling lives inBaseBuilderinstead of being duplicated by the SQLSRV builder.SQLSRV still needs custom table-name qualification, so it now overrides only that small part. JOIN type handling,
ON/USINGcondition compilation, andRawSqlhandling all go through the shared path.This keeps the public API unchanged and preserves existing JOIN string behavior, while reducing driver-specific duplication. It also makes SQLSRV follow the same documented
RawSqljoin-condition behavior as the base builder.Tests cover SQLSRV multi-condition joins and
RawSqljoins.No user guide or changelog entry is included because this does not add a new public API.
Checklist: