Fixed the alignment issue when both crossfade and placeholder are present in AsyncImage.#3240
Open
pb-jithin wants to merge 1 commit into
Open
Fixed the alignment issue when both crossfade and placeholder are present in AsyncImage.#3240pb-jithin wants to merge 1 commit into
pb-jithin wants to merge 1 commit into
Conversation
…espected throughout the rendering chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the alignment issue when both crossfade and placeholder are present in AsyncImage.
The problem was that CrossfadePainter always centered its child painters, overriding the alignment set on AsyncImage.
Changes made:
CrossfadePainter.kt: Added alignment parameter and updated drawPainter() to use alignment instead of centering
AsyncImagePainter.kt: Added alignment property and passed it to maybeNewCrossfadePainter
AsyncImagePainter.android.kt and AsyncImagePainter.nonAndroid.kt: Updated maybeNewCrossfadePainter to accept and pass alignment to CrossfadePainter
ContentPainterModifier.kt: Updated to set alignment on AsyncImagePainter when creating/updating