fix(db): chunk unresolved reference queries during sync#558
Open
msnandhis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Issue #540 reports
codegraph syncfailing on a very large checkout withtoo many SQL variablesnear the end of parsing.getUnresolvedReferencesByFiles()built oneIN (...)query containing every changed file path. Large sync batches can exceed SQLite's bind parameter limit, even though nearby node lookup code already chunks at 500 parameters for portability across SQLite backends.deleteResolvedReferences()had the same largeIN (...)shape for source node IDs, so this patch applies the same batching rule there too.Fix
This updates both unresolved-reference paths to deduplicate inputs and process them in
SQLITE_PARAM_CHUNK_SIZEchunks.That keeps each prepared statement under the existing 500-parameter safety limit while preserving the old behavior for empty inputs and duplicate file paths or node IDs.
Closes #540.
Validation
npx vitest run __tests__/db-perf.test.tsnpx -y -p node@22 -p npm@10 npm run buildnpx -y -p node@22 -p npm@10 npm testgit diff --check