HKG: document 2023 Kia Sportage Plug-in Hybrid - #3545
Conversation
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 260 segments for: HYUNDAI_AZERA_HEV_6TH_GEN, HYUNDAI_ELANTRA_GT_I30, HYUNDAI_ELANTRA_2021, HYUNDAI_ELANTRA_HEV_2021, HYUNDAI_GENESIS, HYUNDAI_IONIQ, HYUNDAI_IONIQ_HEV_2022, HYUNDAI_IONIQ_EV_2020, HYUNDAI_IONIQ_PHEV_2019, HYUNDAI_IONIQ_PHEV, HYUNDAI_KONA_2022, HYUNDAI_KONA_EV, HYUNDAI_KONA_EV_2022, HYUNDAI_KONA_EV_2ND_GEN, HYUNDAI_SANTA_FE, HYUNDAI_SANTA_FE_2022, HYUNDAI_SANTA_FE_HEV_2022, HYUNDAI_SANTA_FE_PHEV_2022, HYUNDAI_SONATA, HYUNDAI_SONATA_LF, HYUNDAI_STARIA_4TH_GEN, HYUNDAI_PALISADE, HYUNDAI_SONATA_HYBRID, HYUNDAI_IONIQ_5, HYUNDAI_IONIQ_6, HYUNDAI_TUCSON_4TH_GEN, HYUNDAI_SANTA_CRUZ_1ST_GEN, HYUNDAI_CUSTIN_1ST_GEN ✅ 0 changed, 260 passed, 0 errors |
|
Some history: I originally submitted the fingerprint and routes for the 2023 Kia Sportage PHEV in commaai/openpilot#30575. @sunnyhaibin implemented the port and moved it to #1138, where @jyoung8607 summarized the remaining lateral-response and stock-alert issues at #1138 (comment). @sshane @xtian and @radicaldancool provided review and additional testing and firmware data. That implementation used camera firmware If the PHEV ever needs to be distinguished, its logged HVAC firmware contains the explicit markers |
Document the 2023 Kia Sportage Plug-in Hybrid as supported under the existing
KIA_SPORTAGE_5TH_GENplatform.Current stock openpilot already identifies this vehicle exactly as
KIA_SPORTAGE_5TH_GENfrom its firmware and applies the correct CAN-FD, hybrid, camera-SCC, and alternate-button configuration. This PR therefore adds only the missing consumer-facing support entry; it does not change fingerprinting, tuning, controller behavior, or safety limits.Validation
428412ad82894ba3428412ad82894ba3/00000005--9ce9a58d79release-tizi, commit commaai/openpilot@70e1574Expand for route and fingerprinting details
The fully uploaded route contains approximately 11.4 minutes of engaged lateral control, including highway driving up to approximately 68 mph and demanding curves. It produced no CAN, steering, vehicle-sensor, or panda faults and no lateral-controller saturation. Physical achieved/requested lateral acceleration had a regression slope of 1.021 overall and 1.013 above 50 mph.
The exact PHEV powertrain is visible in this vehicle's logged HVAC firmware through the markers
NQ5PHandNQ5PHEV. That ECU is currently logging-only and is not needed for this documentation-only change because the existing shared Sportage configuration performs correctly.