fix(monitor-all): reduce polling CPU overhead#15907
Draft
jomplox wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Monitor-All currently launches
pct statusplus up to three separatepct configorqm configcommands for every guest during each polling cycle. Those repeated Proxmox CLI calls add avoidable CPU overhead.This change:
pct configandqm config;mon-restarttag checks.The monitoring policy, exclusions, health checks, restart commands, messages, and 300-second pause are unchanged.
Validation:
bash -n tools/pve/monitor-all.shping-instances.shpayload parses cleanlypct configorqm configlaunches after the changeDevelopment disclosure: OpenAI Codex assisted the diagnosis, patch drafting, and fixture harness. The committed result was manually reviewed and validated before submission.
🔗 Related Issue
None.
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.