rvps: add DeleteReferenceValue RPC and rvps-tool delete command - #1600
Open
AnkushUjawane wants to merge 1 commit into
Open
rvps: add DeleteReferenceValue RPC and rvps-tool delete command#1600AnkushUjawane wants to merge 1 commit into
AnkushUjawane wants to merge 1 commit into
Conversation
RVPS supported registering and querying reference values, and (as of a previous PR) listing them, but had no way to remove one. A stale or mistakenly registered reference value could only be overwritten via register, never actually deleted. Adds a DeleteReferenceValue gRPC RPC, backed by the existing KeyValueStorage::delete() the storage backend already provides (same mechanism KBS's resource plugin already uses for delete), and wires it through to a new 'rvps-tool delete' subcommand. Returns whether something was actually deleted, distinguishing 'deleted' from 'nothing to delete' rather than treating both as success uniformly. attestation-service also implements ReferenceValueProviderService for its built-in and remote-gRPC RVPS modes; updated RvpsApi and both implementors (builtin, grpc) so this doesn't break AS's build, having learned that lesson from the ListReferenceValues PR. Manually verified end-to-end: registered a reference value, listed it, deleted it, confirmed it no longer appears in the list, and confirmed deleting a nonexistent key reports 'not found' rather than erroring. Signed-off-by: AnkushUjawane <multiverse1808@gmail.com>
fitzthum
approved these changes
Aug 28, 2026
fitzthum
left a comment
fitzthum
left a comment
Member
There was a problem hiding this comment.
LGTM
I do have some ideas for a more sophisticated flow for revoking RVs where we actually keep the RV storage but mark it as revoked (so we have a better record of what happened), but this seems fine for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RVPS supported registering and querying reference values, and (as of a previous PR) listing them, but had no way to remove one. A stale or mistakenly registered reference value could only be overwritten via register, never actually deleted.
Adds a DeleteReferenceValue gRPC RPC, backed by the existing KeyValueStorage::delete() the storage backend already provides (same mechanism KBS's resource plugin already uses for delete), and wires it through to a new 'rvps-tool delete' subcommand. Returns whether something was actually deleted, distinguishing 'deleted' from 'nothing to delete' rather than treating both as success uniformly.
attestation-service also implements ReferenceValueProviderService for its built-in and remote-gRPC RVPS modes; updated RvpsApi and both implementors (builtin, grpc) so this doesn't break AS's build, having learned that lesson from the ListReferenceValues PR.
Manually verified end-to-end: registered a reference value, listed it, deleted it, confirmed it no longer appears in the list, and confirmed deleting a nonexistent key reports 'not found' rather than erroring.