docs(crew): correct manager_llm field description#5906
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesManager LLM Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Field description for manager_llm on Crew read 'Language model that will run the agent.', which is the description copied from the llm field rather than the description for manager_llm. The class docstring already describes manager_llm as 'The language model that will run manager agent.' Update the Field description to match: 'Language model that will run the manager agent in hierarchical process.' This makes the schema metadata consistent with the docstring and clarifies that this field is only used when process=Process.hierarchical.
46183e1 to
8b2d24e
Compare
The Field description for
manager_llmonCrewreadsLanguage model that will run the agent., which is the description copied from the siblingllmfield rather than the description formanager_llm. The class docstring already saysmanager_llm: The language model that will run manager agent., so the schema metadata is out of sync with the docstring.This PR updates the Field description to
Language model that will run the manager agent in hierarchical process.so the schema, the docstring, and the runtime use of the field all agree. It also surfaces in the description thatmanager_llmis only consulted whenprocess=Process.hierarchical, which is whatcheck_manager_llmenforces increw.py.The fix is documentation only and does not change runtime behavior.
pytest lib/crewai/tests/test_crew.py -k manager_llmcontinues to pass against the updated description.Summary by CodeRabbit