Skip to content

Michaelb/add end date cli option#8

Open
mbostler wants to merge 8 commits into
dangoslen:mainfrom
stepful:michaelb/add-end-date-cli-option
Open

Michaelb/add end date cli option#8
mbostler wants to merge 8 commits into
dangoslen:mainfrom
stepful:michaelb/add-end-date-cli-option

Conversation

@mbostler

Copy link
Copy Markdown

This PR adds the ability to parse and "end-date" CLI option to restrict the returned metrics to a specific time window.

This was found to be necessary for Q1 26 QBR data collection in order to avoid running into timeout errors when running the script.

This new filter can be activated by passing -e or --end-date option, eg:

./fetch-code-review-metrics.py --repo stepful/stepful --file ./metrics_2026-01-14-full.csv --token ghp_XXX --start-date 2025-10-01 --end-date 2025-10-31

@dangoslen dangoslen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the script, but the rest looks good to me

Comment thread analyze-pr-metrics.py

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that meant to be committed? It is great, but seems like a custom script?

Maybe we could put scripts like this in a /useful-scripts or /analysis directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants