Skip to content

Make linting and type checking more rigorous: black, ruff, mypy all green #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dantzert merged 5 commits into from
Mar 1, 2026
Merged

Make linting and type checking more rigorous: black, ruff, mypy all green #12

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84ee260
Initial plan
Copilot Feb 28, 2026
73125d9
Fix linting issues: imports, whitespace, bare except, undefined names…
Copilot Feb 28, 2026
93e456c
Add modpods.py to CI black and ruff checks
Copilot Feb 28, 2026
2d6dd82
Fix all mypy errors; enable check_untyped_defs and warn_return_any in…
Copilot Feb 28, 2026
2de4ca8
Use . in CI for black, ruff, and mypy to cover whole repo; fix spring…
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
run: pip install -r requirements.txt

- name: Lint with black
run: black --check tests/
run: black --check modpods.py tests/

@dantzert dantzert Feb 28, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "black ."? To apply across the whole repo?

Copilot AI Feb 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to black --check . in commit 2de4ca8. Also fixed the two additional files that needed reformatting (spring-cart-interactive.py) and the F403 star import in __init__.py.


- name: Lint with ruff
run: ruff check tests/
run: ruff check modpods.py tests/

@dantzert dantzert Feb 28, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "ruff check ."?

Copilot AI Feb 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to ruff check . in commit 2de4ca8. Fixed the ruff violations in spring-cart-interactive.py (import sorting, trailing whitespace, unused variable) and added # noqa: F403 to the intentional star import in __init__.py.


- name: Type-check with mypy
run: mypy tests/ modpods.py --ignore-missing-imports
Expand Down
Loading