direct: Pass id to WaitAfterXXX methods#5258
Merged
Merged
Conversation
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
May 18, 2026
janniklasrose
added a commit
that referenced
this pull request
May 18, 2026
… remote - WaitAfterCreate now takes id per #5258; the saved config.Name is the same as id, so the body is unchanged. - SDK v0.132.0 (#5237) returns delta_sync_index_spec.columns_to_sync (and the new columns_to_index field) on read. Drop the ignore_remote_changes rule and propagate both from remote in RemapState. Removes the drift/columns_to_sync acceptance test which was asserting the now-stale request-only behavior. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pass id to WaitAfterXXX methods
Why
Follow up from here #5150 (comment)
Tests
Tests pas