acceptance: use templates for bundle_default_profile scenarios#5270
Merged
janniklasrose merged 2 commits intoMay 21, 2026
Conversation
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Replace inline heredocs and per-scenario subdirectories
(./bundle-with-host, ./bundle-with-profile) with three committed
template files: databricks.yml.{no-host,with-host,with-profile}.tmpl.
The script copies (or envsubsts, for the host-pinned template) the
active template into databricks.yml before each phase, so the active
bundle is always at the test root.
Follows pietern's suggestion in #5214.
Co-authored-by: Isaac
janniklasrose
force-pushed
the
janniklasrose/default-profile-test-templates
branch
from
cde4305 to
4ddfb5e
Compare
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
May 21, 2026
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5214 (per pietern's review comment).
Replace the inline heredocs in
acceptance/auth/bundle_default_profile/scriptwith three committed templates:databricks.yml.no-host.tmpl— bundle with neitherworkspace.hostnorworkspace.profile. Used for the "default_profile is honored" and "--profileoverrides" phases.databricks.yml.with-host.tmpl— pinsworkspace.host: $DATABRICKS_HOST.envsubstfills in the test server URL before each invocation.databricks.yml.with-profile.tmpl— pinsworkspace.profile: other.Before each phase the script overwrites the active
databricks.ymlfrom the relevant template. The per-scenario subdirectories (./bundle-with-host,./bundle-with-profile) and thecdcalls are gone — the active bundle is always at the test root.Stacked on #5266 (sethome-absolute fix). The base will auto-retarget to
mainonce #5266 merges.output.txtis unchanged across the refactor: both engine variants (terraformanddirect) produce byte-identical output to the pre-refactor run.Test plan
go test ./acceptance -run TestAccept/auth/bundle_default_profile -vpasses for bothDATABRICKS_BUNDLE_ENGINE=terraformand=direct../task fmt-qand./task lint-qclean.This pull request and its description were written by Isaac.