Require DuckDB DDL on every SQL profiler step - #2597
Open
dgomez04 wants to merge 4 commits into
Open
Conversation
Fold paired ddl+sql extracts into a single sql step with ddl_source so schemas are always explicit and overwrite recreates typed tables before insert.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
+ Coverage 71.45% 71.54% +0.08%
==========================================
Files 108 108
Lines 9796 9802 +6
Branches 1087 1089 +2
==========================================
+ Hits 7000 7013 +13
+ Misses 2572 2565 -7
Partials 224 224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ 181/181 passed, 9 flaky, 2 skipped, 1h10m38s total Flaky tests:
Running from acceptance #5214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ddl_sourcerequired on everytype: sqlprofiler step so DuckDB schemas are always explicit (no inferred CTAS path).ddl+sqlsteps into a single SQL step; add DuckDB DDL for Snowflake, Redshift, and legacy Synapse.Resolves #2460
Test plan
pytest tests/unit/assessment/ -q(213 passed)source_ddlRedshift steps still run unchanged