Revert "Revert "Correctly use local template for tasks if available during dr run""#538
Revert "Revert "Correctly use local template for tasks if available during dr run""#538carsongee wants to merge 7 commits into
dr run""#538Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 376 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 365 | 3 | 8 | 0 |
Click to see the invalid file list
- cmd/task/run/testdata/recipe/.Taskfile.template
- cmd/task/run/cmd_test.go
- cmd/task/run/testdata/recipe/Taskfile.yml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
|
❌ Some smoke tests failed. ❌ Linux: failure |
|
❌ Some smoke tests failed. ❌ Linux: cancelled |
|
@carsongee This looks good to me but please note that smoke tests are failing. |
carsongee
force-pushed
the
revert-537-revert-530-carsongee/use_templated_taskfile
branch
from
8a32720 to
93bae1f
Compare
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
carsongee
added
run-smoke-tests
run-install-tests
and removed
run-smoke-tests
run-install-tests
labels
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
|
❌ Some smoke tests failed. ❌ Linux: failure |
|
❌ Some smoke tests failed. ❌ Linux: failure |
1 similar comment
|
❌ Some smoke tests failed. ❌ Linux: failure |
…uring `d…" This reverts commit ebf3ef2.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
carsongee
force-pushed
the
revert-537-revert-530-carsongee/use_templated_taskfile
branch
2 times, most recently
from
93bae1f to
6e7308b
Compare
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
|
✅ All smoke tests passed! ✅ Linux: success |
2 participants
Reverts #537
Changes since original merge
Note
Low Risk
Refactors taskfile generation/discovery only; no auth, data, or deployment path changes beyond matching local template behavior for
dr run.Overview
Task discovery is consolidated into
task.NewDiscoveryininternal/task, replacing duplicate logic in the compose command (createDiscovery/validateTemplatePath).dr runnow uses that shared path instead of onlyNewTaskDiscovery, so generatedTaskfile.gen.yamlcan use a project-root.Taskfile.templatewhen no--templateis passed. Auto-detection of that file moved from compose-time setup intoDiscover(), keyed off the project root.Compose still passes an explicit template via the flag when set; empty template defers to runtime detection during discovery.
Reviewed by Cursor Bugbot for commit ebfbb1a. Configure here.