Skip to content

[CFX-6347] Disable telemetry key injection so it will block telemetry run.#544

Open
cdevent wants to merge 1 commit into
mainfrom
cdevent/CFX-6347
Open

[CFX-6347] Disable telemetry key injection so it will block telemetry run.#544
cdevent wants to merge 1 commit into
mainfrom
cdevent/CFX-6347

Conversation

@cdevent

@cdevent cdevent commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

RATIONALE

This pull request makes a small but important change to the goreleaser.yaml build configuration by temporarily disabling the inclusion of the Amplitude telemetry API key in the build process, pending legal approval. The code and comment clarify how to re-enable telemetry once approved.

  • Temporarily removed the AmplitudeAPIKey from the ldflags in the build configuration, with a comment explaining this is pending legal approval and instructions for re-enabling it in the future.

CHANGES

PR Automation

Comment-Commands: Trigger CI by commenting on the PR:

  • /trigger-smoke-test or /trigger-test-smoke - Run smoke tests
  • /trigger-install-test or /trigger-test-install - Run installation tests

Labels: Apply labels to trigger workflows:

  • run-smoke-tests or go - Run smoke tests on demand (only works for non-forked PRs)

Important

For Forked PRs: The run-smoke-tests label won't work. A required Smoke Tests check will block merge until a maintainer acts:

  • A maintainer uses /approve-smoke-tests to run smoke tests (results will set the check)
  • A maintainer uses /skip-smoke-tests to bypass the check without running tests

Please comment requesting a maintainer review if you need smoke tests to run.


Note

Low Risk
Build-only change that disables telemetry in release artifacts; no runtime logic or auth/data paths are modified.

Overview
Release builds will no longer embed the Amplitude API key via GoReleaser ldflags, so shipped dr binaries keep AmplitudeAPIKey empty and telemetry stays off until legal approval (same behavior as dev builds when the key is unset).

The removed -X line is preserved in a comment with instructions to restore it and wire AMPLITUDE_API_KEY when re-enabling. Other release ldflags (version, git commit, build date, install method) are unchanged.

Reviewed by Cursor Bugbot for commit 6204ed0. Configure here.

@cdevent cdevent marked this pull request as ready for review June 2, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant