[CFX-6347] Disable telemetry key injection so it will block telemetry run.#544
Open
cdevent wants to merge 1 commit into
Open
[CFX-6347] Disable telemetry key injection so it will block telemetry run.#544cdevent wants to merge 1 commit into
cdevent wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
This pull request makes a small but important change to the
goreleaser.yamlbuild configuration by temporarily disabling the inclusion of the Amplitude telemetry API key in the build process, pending legal approval. The code and comment clarify how to re-enable telemetry once approved.AmplitudeAPIKeyfrom theldflagsin the build configuration, with a comment explaining this is pending legal approval and instructions for re-enabling it in the future.CHANGES
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: The
run-smoke-testslabel won't work. A required Smoke Tests check will block merge until a maintainer acts:/approve-smoke-teststo run smoke tests (results will set the check)/skip-smoke-teststo bypass the check without running testsPlease comment requesting a maintainer review if you need smoke tests to run.
Note
Low Risk
Build-only change that disables telemetry in release artifacts; no runtime logic or auth/data paths are modified.
Overview
Release builds will no longer embed the Amplitude API key via GoReleaser
ldflags, so shippeddrbinaries keepAmplitudeAPIKeyempty and telemetry stays off until legal approval (same behavior as dev builds when the key is unset).The removed
-Xline is preserved in a comment with instructions to restore it and wireAMPLITUDE_API_KEYwhen re-enabling. Other releaseldflags(version, git commit, build date, install method) are unchanged.Reviewed by Cursor Bugbot for commit 6204ed0. Configure here.