docs(130): post-delivery quality review#150
Merged
davidmatousek merged 4 commits intomainfrom Apr 11, 2026
Merged
Conversation
- Extract _build_error_record() helper to dedupe the stderr-decode dance across CalledProcessError and TimeoutExpired branches in _render_single (was ~12 lines of copy-paste). - Inline single-use aliases in _render_single; trim verbose module-state comment to one sentence. - Consolidate per-test boilerplate in test_mmdc_preflight.py via a new render_dirs fixture (saves ~30 lines of target_dir/template_dir duplication across 8 tests). - Delete test_preflight_skipped_when_only_low_medium_findings — it was byte-identical to test_preflight_skipped_when_attack_trees_empty. - Fix _make_error_record type annotation: stderr: "bytes | str". - Drop task/refinement/FR-ID references from module and section comments per KB-027 (they rot after the feature closes). Test suite: 47/48 pass (dropped 1 duplicate), backward-compat baselines unchanged. Net: -138 lines. Co-Authored-By: Claude <noreply@anthropic.com>
Issue #130 transitioned from stage:deliver to stage:done during the delivery retrospective — remove it from the active-backlog table. Co-Authored-By: Claude <noreply@anthropic.com>
Add Unreleased entry describing the mmdc hard-prerequisite posture, defense-in-depth preflight gates, mid-render failure aggregator, backward-compatibility guarantees, and documentation sync. Mirrors the Feature 136 narrative style for correctness-fix breaking changes. Release-please will pick this up on the next release. Co-Authored-By: Claude <noreply@anthropic.com>
The /aod.document simplify pass deleted a byte-identical duplicate preflight test. Reflect the new post-simplify test count (47/48, 8 distinct new cases instead of 9) in KB-029. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-delivery documentation review for Feature 130 (mmdc hard prerequisite fix).
refactor(130): simplify code per /simplify review— extracts_build_error_record()helper to dedupe stderr-decode logic across CalledProcessError/TimeoutExpired branches in_render_single; adds arender_dirspytest fixture to eliminate ~30 lines of per-test directory boilerplate; deletes a byte-identical duplicate preflight test; drops task/refinement/FR-ID references from comments per KB-027 anti-pattern. Net: -138 lines acrossscripts/extract-report-data.pyandtests/scripts/test_mmdc_preflight.py. Test suite: 47/48 pytest pass (delta = 1 duplicate removed); backward-compat baselines unchanged.chore(130): regenerate BACKLOG.md after #130 closure— Issue Fix attack path Mermaid rendering when mmdc is not installed (spec 112 follow-up) #130 transitioned to stage:done during the delivery retrospective; regenerate the active-backlog table.docs(130): update CHANGELOG with Feature 130 breaking change entry— Unreleased section narrative describing the mmdc hard-prerequisite posture, defense-in-depth preflight gates, mid-render aggregator, backward compatibility, and doc sync. Mirrors the Feature 136 narrative style.docs(130): review KB entries — update KB-029 test counts post-simplify— reflect the new 47/48 / 8-distinct-case post-simplify state in the KB entry.🤖 Generated with Claude Code