Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.2.2 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deargvp1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.2.2 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appengine/standard/firebase/firenotes/backend/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ google-auth==2.17.3; python_version > '3.0'
Werkzeug==3.1.8; python_version >= '3.9'
requests==2.34.2; python_version >= '3.10'
requests-toolbelt==1.0.0
urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In requirements.txt, it is best practice to pin dependencies to exact versions using == rather than >=. This ensures reproducible builds and prevents unexpected breaking changes when new versions of the package are released. Consider pinning urllib3 to 2.2.2 exactly.

urllib3==2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Missing Python version marker on urllib3 dependency — will break installation on Python 2.7 (the project's target runtime per app.yaml). urllib3 2.2.2 requires Python >= 3.8, but the new line has no python_version constraint.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At appengine/standard/firebase/firenotes/backend/requirements.txt, line 9:

<comment>Missing Python version marker on urllib3 dependency — will break installation on Python 2.7 (the project's target runtime per app.yaml). urllib3 2.2.2 requires Python >= 3.8, but the new line has no `python_version` constraint.</comment>

<file context>
@@ -6,3 +6,4 @@ google-auth==2.17.3; python_version > '3.0'
 Werkzeug==3.1.8; python_version >= '3.9'
 requests==2.34.2; python_version >= '3.10'
 requests-toolbelt==1.0.0
+urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>
Suggested change
urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
urllib3>=2.2.2; python_version >= '3.10' # not directly required, pinned by Snyk to avoid a vulnerability

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Use ==2.2.2 instead of >=2.2.2 to be consistent with all other dependencies in this file and to actually pin the version as the inline comment states. Using >= allows arbitrary future versions to be installed, which undermines reproducibility and could introduce regressions.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At appengine/standard/firebase/firenotes/backend/requirements.txt, line 9:

<comment>Use `==2.2.2` instead of `>=2.2.2` to be consistent with all other dependencies in this file and to actually pin the version as the inline comment states. Using `>=` allows arbitrary future versions to be installed, which undermines reproducibility and could introduce regressions.</comment>

<file context>
@@ -6,3 +6,4 @@ google-auth==2.17.3; python_version > '3.0'
 Werkzeug==3.1.8; python_version >= '3.9'
 requests==2.34.2; python_version >= '3.10'
 requests-toolbelt==1.0.0
+urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>
Suggested change
urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
urllib3==2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability