fix(decopilot): destructive tools require user approval and new model allow all#3267
Open
fix(decopilot): destructive tools require user approval and new model allow all#3267
Conversation
Tools annotated with destructiveHint: true now always prompt for approval regardless of the tool-approval level setting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
…tools The "auto" level now asks before executing destructive tools. A new "YOLO" level skips all approval prompts, including destructive ones. Three-tier approval: readonly → auto → yolo Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🧐🥴 |
guitavano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
destructiveHint: truenow always require user approval, regardless of theToolApprovalLevelsetting (autoorreadonly)destructiveHintwas only used for UI badges and analytics — the approval gate only checkedreadOnlyHintannotations.destructiveHinttotoolNeedsApprovalTest plan
autoapproval level🤖 Generated with Claude Code
Summary by cubic
Destructive MCP tools with
destructiveHint: truenow require approval onautoandreadonly. A newtrust-alllevel skips all approval prompts, including destructive tools. Passthrough tools now forwardannotations.destructiveHinttotoolNeedsApproval.trust-allToolApprovalLevel;toolNeedsApprovalauto-approves everything ontrust-all.trust-allwith clear labels; preferences validation acceptstrust-all.trust-alland destructive approval; plan mode still hard-blocks non-read-only tools.Written for commit ed93659. Summary will update on new commits.