Draft
Conversation
Replace the in-repo badge renderer with badge-maker-rs, add Shields-compatible style parsing for plastic and social, and remove the obsolete libs/badge workspace crate. Co-authored-by: OpenAI Codex <codex@openai.com>
Member
I don't see any reason not to support it give we (now) get it for free.
... even if it is ugly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR replaces the in-repo badge renderer with
badge-maker-rsand adds Shields-compatiblestylequery parsing.Closes #245.
Changes:
libs/badgeworkspace cratebadge-maker-rs?style=...Open questions
style=socialcurrently does not preserve the color-based status signal, so dependency states are harder to distinguish at a glancestyle,subject, andcompactare still not very discoverable from the UIFollow-up
Before marking this ready for review, we should:
style=social