Skip to content

fix(lint): skip POP-105 for GRPC probes (must use port numbers) #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beltagyy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(lint): skip POP-105 for GRPC probes (must use port numbers) #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/lint/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,16 @@ func (c *Container) checkProbes(ctx context.Context, co v1.Container) {
}

func (c *Container) checkNamedProbe(ctx context.Context, p *v1.Probe, liveness bool) {
if p == nil || p.ProbeHandler.HTTPGet == nil {
if p == nil {
return
}
// GRPC probes must use port numbers (not named ports).
// Skip POP-105 check for GRPC to avoid false positives.
// https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.35/#grpcaction-v1-core
if p.ProbeHandler.GRPC != nil {
return
}
if p.ProbeHandler.HTTPGet == nil {
return
}
kind := "Readiness"
Expand Down
5 changes: 5 additions & 0 deletions internal/lint/container_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ func TestContainerCheckProbes(t *testing.T) {
liveness bool
readiness bool
namedPort bool
grpcProbe bool
issues int
severity rules.Level
}{
Expand All @@ -142,6 +143,7 @@ func TestContainerCheckProbes(t *testing.T) {
"noLive": {readiness: true, issues: 1, severity: rules.WarnLevel},
"noneProbes": {issues: 1, severity: rules.WarnLevel},
"Unnamed": {liveness: true, readiness: true, namedPort: true, issues: 2, severity: rules.InfoLevel},
"GRPCNoIssue": {liveness: true, readiness: true, grpcProbe: true},
}

ctx := test.MakeContext("containers", "container")
Expand All @@ -152,6 +154,9 @@ func TestContainerCheckProbes(t *testing.T) {
if u.namedPort {
probe.ProbeHandler = v1.ProbeHandler{HTTPGet: &v1.HTTPGetAction{Port: intstr.Parse("80")}}
}
if u.grpcProbe {
probe.ProbeHandler = v1.ProbeHandler{GRPC: &v1.GRPCAction{Port: 80}}
}
if u.liveness {
co.LivenessProbe = probe
}
Expand Down