Clean Cargo artifacts between WASM variants#965
Open
PoseidonEnergy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
cargo cleanstep before eachwasm-packbuild inrapier-compat.The build variants share the same Cargo target directory but use different
RUSTFLAGS, particularly for SIMD and non-SIMD builds. Without cleaning, for me, Cargo reuses artifacts compiled with incompatible target features, causing non-SIMD builds to contain SIMD instructions and fail duringwasm-optvalidation.Cleaning before each variant ensures every WASM package is rebuilt with the correct compiler flags.