Skip to content

docs: fix stale defaults, wrong tool names, and missing CLI flags#3043

Merged
aheritier merged 1 commit into
docker:mainfrom
dgageot:board/6f9922e545045ff0
Jun 10, 2026
Merged

docs: fix stale defaults, wrong tool names, and missing CLI flags#3043
aheritier merged 1 commit into
docker:mainfrom
dgageot:board/6f9922e545045ff0

Conversation

@dgageot

@dgageot dgageot commented Jun 9, 2026

Copy link
Copy Markdown
Member

A full review of the docs site against the current code turned up a number of claims that were false or out of date. This fixes all of them, verified against the CLI help output, agent-schema.json, and the relevant Go packages.

The biggest offenders were the config version (documented as 8, current is 10), the Anthropic/Bedrock thinking defaults (several pages contradicted each other; per pkg/model/provider/defaults.go, thinking is off unless thinking_budget is set and interleaved_thinking is then auto-enabled for Claude models), and the model-picker page, which documented a pick_model tool that does not exist — the real tools are change_model and revert_model, and the switch is immediate rather than next-turn.

Smaller fixes: the serve a2a --agent default is the team's first agent, not root; the filesystem post-edit hook docs referenced a nonexistent patch_file tool; the RAG pages used batch_size instead of embedding_batch_size and documented wrong defaults for chunk size and reranking top_k; and the CLI/TUI references were missing --theme, --on-event, --tool-name, --mcp-keepalive, --attach, and the /skills command. Docs-only change, no code touched.

@dgageot dgageot requested a review from a team as a code owner June 9, 2026 20:27
@aheritier aheritier added area/cli CLI commands, flags, output formatting area/config For configuration parsing, YAML, environment variables area/providers/anthropic For features/issues/fixes related to the usage of Anthropic models area/providers/bedrock AWS Bedrock provider support area/rag For work/issues that have to do with the RAG features area/tools For features/issues/fixes related to the usage of built-in and MCP tools area/tui For features/issues/fixes related to the TUI kind/docs Documentation-only changes labels Jun 9, 2026
@docker-agent

Copy link
Copy Markdown

PR Review Failed — The review agent encountered an error and could not complete the review. View logs.

@aheritier aheritier added the area/agent For work that has to do with the general agent loop/agentic features of the app label Jun 10, 2026
@aheritier aheritier merged commit d89168a into docker:main Jun 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent For work that has to do with the general agent loop/agentic features of the app area/cli CLI commands, flags, output formatting area/config For configuration parsing, YAML, environment variables area/providers/anthropic For features/issues/fixes related to the usage of Anthropic models area/providers/bedrock AWS Bedrock provider support area/rag For work/issues that have to do with the RAG features area/tools For features/issues/fixes related to the usage of built-in and MCP tools area/tui For features/issues/fixes related to the TUI kind/docs Documentation-only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants